fix(service_biz.nu): drop BASE_PATH env per hero_web_prefix skill (home#230 phase 2.1) #241

Merged

mik-tf merged 1 commit from development_mik_basepath_purge into development

2026-05-08 15:22:30 +00:00

mik-tf commented

2026-05-08 15:19:25 +00:00

Owner

Summary

Companion to hero_biz #49. Per hero_web_prefix skill (line 38), there is no BASE_PATH env var — X-Forwarded-Prefix header from hero_router is the sole source of truth, default "" on direct access.

Removes BASE_PATH from svx_ui_action's env block in service_biz.nu. Updates the file-level comment to record why it was removed.

Supersedes

c0186425 renamed the value /hero_biz/ui → /hero_biz/admin instead of deleting the env var. This PR deletes it.

Test plan

nu -c "use nutools/modules/services/service_biz.nu *" parses.
On herodemo: service_biz start --download --version v0.5.0-rc1 --reset — process starts cleanly, /hero_biz/admin/ renders with prefix-aware links.

Refs

home#230 phase 2.1 — alignment audit
hero_biz #49 — companion crate-side changes
hero_demo 809a7e8 — companion TOML change

Signed-off-by: mik-tf

## Summary Companion to [hero_biz #49](https://forge.ourworld.tf/lhumina_code/hero_biz/pulls/49). Per [`hero_web_prefix`](https://forge.ourworld.tf/lhumina_code/home/issues/230) skill (line 38), there is no `BASE_PATH` env var — `X-Forwarded-Prefix` header from hero_router is the sole source of truth, default `""` on direct access. Removes `BASE_PATH` from `svx_ui_action`'s env block in `service_biz.nu`. Updates the file-level comment to record why it was removed. ## Supersedes [c0186425](https://forge.ourworld.tf/lhumina_code/hero_skills/commit/c018642550ed4077bf499ca566618c72814e50b6) renamed the value `/hero_biz/ui` → `/hero_biz/admin` instead of deleting the env var. This PR deletes it. ## Test plan - [x] `nu -c "use nutools/modules/services/service_biz.nu *"` parses. - [ ] On herodemo: `service_biz start --download --version v0.5.0-rc1 --reset` — process starts cleanly, `/hero_biz/admin/` renders with prefix-aware links. ## Refs - [home#230](https://forge.ourworld.tf/lhumina_code/home/issues/230) phase 2.1 — alignment audit - [hero_biz #49](https://forge.ourworld.tf/lhumina_code/hero_biz/pulls/49) — companion crate-side changes - [hero_demo 809a7e8](https://forge.ourworld.tf/lhumina_code/hero_demo/commit/809a7e8) — companion TOML change Signed-off-by: mik-tf

mik-tf added 1 commit

2026-05-08 15:19:25 +00:00

fix(service_biz): drop BASE_PATH env var per hero_web_prefix skill

Build and Publish Skills / build-and-publish (pull_request) Failing after 3s

Details

4306918604

The `hero_web_prefix` skill (line 38) is explicit: "There is no
BASE_PATH environment variable. The proxy is the only source of truth
for the prefix." The X-Forwarded-Prefix header injected by hero_router
on every routed request is the sole input; direct access (no header)
yields an empty prefix.

Removes BASE_PATH from svx_ui_action's env block. Companion change:
hero_biz crate drops std::env::var("BASE_PATH") read in
hero_biz_admin/src/web/server.rs and the AppState.base_path field.
hero_router and hero_demo follow with their own one-line drops.

Supersedes c0186425 (which renamed the value /hero_biz/ui →
/hero_biz/admin instead of deleting it).

Refs:
- lhumina_code/home#230 — alignment audit
- lhumina_code/home#225 — META rule umbrella
- ~/.claude/skills/hero_web_prefix/SKILL.md line 38

Signed-off-by: mik-tf