fix(packages.nu): add service_books + service_office to starts_extra #240
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_skills!240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "development_mik_books_office_starts_extra"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
service_completewas registering+starting only 16 of the 18 services that havestartcommands accepting--download/--version. Bothservice_booksandservice_officehave the install closure (lines 79 and 90) but were missing from the start closure list.hero_bookson the demo VM was install+started by hand (s76 #3 carryover, deferred through s77).hero_officequietly never appeared inproc service listafterservice_complete --downloaddespite having a cleanv0.1.0-rc2Forgejo release with 3 musl assets.Why both in one PR (vs the s78 plan that called for books only)
Same one-line change, same failure mode, same fix. Adding
service_officehere closes the same class of gap and unblocks the from-nothing 18/18 target for session-78 DO re-validation under home#230 phase 5. If you'd rather split them, happy to revert office to a separate one-line PR.Test plan
nu -c "use nutools/modules/services/packages.nu *"— parses.service_complete --download --resetproduces 18 entries inproc service list(vs 16 today). To be checked during phase 5 re-validation.service_books install --downloadandservice_office install --downloadalready smoke-tested green on heroci in s52 (books) and s68 (office); only the orchestrator wiring was missing.Refs
starts_extrawas deferred from session 76 item 3 through session 77.