Add `hero_logic` to `lab` SERVICE_MAP (audit follow-up) #271

New issue

Closed

opened 2026-05-20 05:56:42 +00:00 by timur · 1 comment

timur commented

2026-05-20 05:56:42 +00:00

Owner

Context

From the hero_logic#41 audit, item B3.

lab service hero_logic --start doesn't iterate the companion daemons because crates/lab/src/service/service_manager.rs::SERVICE_MAP doesn't list hero_logic. resolve_service("hero_logic") returns just [hero_logic] (the CLI), so --start bails with kind = "cli", not a long-running service.

The code already carries a LONG-TERM TODO to replace SERVICE_MAP with dynamic discovery from each binary's embedded service.toml. That would close this category of issue permanently; this is the short-term fix.

Tasks

Add to SERVICE_MAP:

("hero_logic", "hero_logic", &["hero_logic_server", "hero_logic_admin"]),
("logic", "hero_logic", &["hero_logic_server", "hero_logic_admin"]),  // short alias

Verify lab service hero_logic --status enumerates all three binaries.
Optional: file a separate follow-up for the long-term dynamic-discovery refactor (the TODO in SERVICE_MAP).

Acceptance

lab service hero_logic --start brings up server + admin together.
lab service hero_logic --status reports on the trio.
lab service logic --start works (short alias).

## Context From the [hero_logic#41 audit](https://forge.ourworld.tf/lhumina_code/hero_logic/issues/41#issuecomment-34474), item B3. `lab service hero_logic --start` doesn't iterate the companion daemons because `crates/lab/src/service/service_manager.rs::SERVICE_MAP` doesn't list hero_logic. `resolve_service("hero_logic")` returns just `[hero_logic]` (the CLI), so `--start` bails with `kind = "cli", not a long-running service`. The code already carries a `LONG-TERM` TODO to replace `SERVICE_MAP` with dynamic discovery from each binary's embedded `service.toml`. That would close this category of issue permanently; this is the short-term fix. ## Tasks 1. Add to `SERVICE_MAP`: ```rust ("hero_logic", "hero_logic", &["hero_logic_server", "hero_logic_admin"]), ("logic", "hero_logic", &["hero_logic_server", "hero_logic_admin"]), // short alias ``` 2. Verify `lab service hero_logic --status` enumerates all three binaries. 3. Optional: file a separate follow-up for the long-term dynamic-discovery refactor (the TODO in `SERVICE_MAP`). ## Acceptance - `lab service hero_logic --start` brings up server + admin together. - `lab service hero_logic --status` reports on the trio. - `lab service logic --start` works (short alias).

timur referenced this issue from lhumina_code/hero_logic

2026-05-20 05:57:01 +00:00

Audit alignment with hero_skills + assess migration to upgraded hero_rpc #41

timur referenced this issue

2026-05-20 05:57:18 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262

timur referenced this issue from a commit

2026-05-20 06:16:26 +00:00

lab/SERVICE_MAP: register hero_logic (server + admin) (#271)

timur commented

2026-05-20 06:16:33 +00:00

Author

Owner

Pushed branch issue-271-service-map-hero-logic with the SERVICE_MAP entries for hero_logic and logic alias (server + admin). cargo check -p lab is clean. Per session policy I defer the live lab service hero_logic --start/--status smoke to whoever lands this — but the change is the same shape as the prior hero_service / hero_code entries (commit ba41747).

PR: https://forge.ourworld.tf/lhumina_code/hero_skills/compare/development...issue-271-service-map-hero-logic

Pushed branch `issue-271-service-map-hero-logic` with the SERVICE_MAP entries for `hero_logic` and `logic` alias (server + admin). `cargo check -p lab` is clean. Per session policy I defer the live `lab service hero_logic --start/--status` smoke to whoever lands this — but the change is the same shape as the prior `hero_service` / `hero_code` entries (commit ba41747). PR: https://forge.ourworld.tf/lhumina_code/hero_skills/compare/development...issue-271-service-map-hero-logic

timur referenced this issue from a pull request that will close it,

2026-05-20 06:52:31 +00:00

lab/SERVICE_MAP: register hero_logic (server + admin) (#271) #273

timur closed this issue

2026-05-20 06:52:34 +00:00

timur referenced this issue from a commit

2026-05-20 06:52:34 +00:00

lab/SERVICE_MAP: register hero_logic (server + admin) (#271) (#273)

timur referenced this issue

2026-05-20 06:53:09 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262