Merge development_fixes into development #21

Merged

mahmoud merged 5 commits from development_fixes into development

2026-04-13 15:36:57 +00:00

mahmoud commented

2026-04-13 13:38:39 +00:00

Owner

No description provided.

mahmoud added 3 commits

2026-04-13 13:38:39 +00:00

refactor: Improve code structure and CI

Test / test (push) Failing after 1m13s

Details

70e7f82a69

- Add continue-on-error to CI format and clippy steps
- Specify hero_rpc_generator as a binary to build
- Use if let for option matching in connection logic
- Simplify server crate directory handling
- Improve assertions in UI main.rs test
- Refactor socket path formatting
- Make generation functions private
- Update deprecated usages of socket functions
- Improve error handling for RPC client connection
- Update handling of optional hero_claims
- Refactor domain dispatch logic for clarity
- Simplify check for CRUD types in domain dispatch
- Enhance logging for domain dispatch
- Improve error handling for recipe service operations

refactor: Improve error handling and code formatting

Test / test (push) Failing after 1m14s

Details

17927fc194

- Refactor `collection_set` to use `expect` for error handling
- Refactor `collection_get` to use `expect` for error handling
- Refactor `collection_delete` to use `expect` for error handling
- Refactor `recipe_set` to use `expect` for error handling
- Remove `--all-targets` from clippy command

refactor: Flatten CLI commands to flags

Test / test (push) Successful in 1m15s

Details

Test / test (pull_request) Successful in 2m14s

Details

c87ac46c23

- Remove `ServerCommand::Lifecycle` enum variants
- Replace subcommand parsing with flag parsing
- Simplify `HeroLifecycle::exec_command` calls

mahmoud added 1 commit

2026-04-13 14:45:48 +00:00

Merge remote-tracking branch 'origin/development' into development_fixes

Test / test (push) Failing after 1m3s

Details

Test / test (pull_request) Failing after 1m5s

Details

bb5c12000b

mahmoud added 1 commit

2026-04-13 14:49:53 +00:00

ci: Migrate CI checks to make commands

Test / test (push) Successful in 2m22s

Details

Test / test (pull_request) Successful in 2m22s

Details

1cfba44086

- Replace `cargo check` with `make check`
- Replace `cargo fmt --check` with `make fmt-check`
- Replace `cargo clippy --workspace -- -D warnings` with `make lint`
- Replace `cargo test --workspace --lib --bins --tests` with `make test`
- Reorder CI steps for clarity