lhumina_code/hero_rpc
22
0
Fork 0
Code Issues 8 Pull requests 3 Projects Releases 1 Packages Wiki Activity Actions

feat: implement ADR 001 — configurable socket and data paths (Phase 1) #20

Closed
delandtj wants to merge 1 commit from feat/parametrized-socket-path-optionality into development
pull from: feat/parametrized-socket-path-optionality
merge into: lhumina_code:development
Conversation 1 Commits 1 Files changed 13 +232 -135
delandtj commented 2026-04-08 15:34:52 +00:00
Member
Copy link

Add optional socket_dir/data_dir fields to OServerConfig with
builder methods and HERO_SOCKET_DIR/HERO_DATA_DIR env var fallback.
Convert static path helpers to instance methods and thread config
through OServer → DomainServer/CoreServer/Registry.

Resolution order: config field > env var > ~/hero/var/ default.
Zero breaking change for existing callers — defaults unchanged.

Add optional socket_dir/data_dir fields to OServerConfig with builder methods and HERO_SOCKET_DIR/HERO_DATA_DIR env var fallback. Convert static path helpers to instance methods and thread config through OServer → DomainServer/CoreServer/Registry. Resolution order: config field > env var > ~/hero/var/ default. Zero breaking change for existing callers — defaults unchanged.
Add optional socket_dir/data_dir fields to OServerConfig with
builder methods and HERO_SOCKET_DIR/HERO_DATA_DIR env var fallback.
Convert static path helpers to instance methods and thread config
through OServer → DomainServer/CoreServer/Registry.

Resolution order: config field > env var > ~/hero/var/ default.
Zero breaking change for existing callers — defaults unchanged.
delandtj force-pushed feat/parametrized-socket-path-optionality from 84851e923a to 7eba4fb291
Some checks failed
Test / test (pull_request) Failing after 40s
Details
2026-04-09 08:32:09 +00:00 Compare
delandtj force-pushed feat/parametrized-socket-path-optionality from 7eba4fb291
Some checks failed
Test / test (pull_request) Failing after 40s
Details
to 95a416f360
Some checks failed
Test / test (pull_request) Failing after 59s
Details
2026-04-09 08:36:10 +00:00 Compare
timur commented 2026-04-19 14:59:47 +00:00
Owner
Copy link

Superseded by PR #26 (refactor: ADR 001 — crate topology, OSIS defat, unified server, SDK UI). PR #26 implements the same three-tier path cascade (instance override → env var → default) plus the broader topology/header-parsing refactor. Closing this as obsolete.

Superseded by PR #26 (refactor: ADR 001 — crate topology, OSIS defat, unified server, SDK UI). PR #26 implements the same three-tier path cascade (instance override → env var → default) plus the broader topology/header-parsing refactor. Closing this as obsolete.
timur closed this pull request 2026-04-19 14:59:49 +00:00
Some checks failed
Test / test (pull_request) Failing after 59s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_rpc!20
No description provided.