[build] hero_proc_lib_ui dep hardcodes /Volumes/T7 macOS path — blocks build for everyone else #81

New issue

Open

opened 2026-05-01 15:10:34 +00:00 by mik-tf · 0 comments

mik-tf commented

2026-05-01 15:10:34 +00:00

Owner

Summary

Cargo.toml:25 in [workspace.dependencies] hardcodes a macOS dev path that doesn't exist on any other machine:

hero_proc_lib_ui = { path = "/Volumes/T7/code0/hero_proc/crates/hero_proc_lib_ui", version = "0.5.0" }

Build fails for anyone not on that laptop:

error: failed to load manifest for workspace member `.../hero_router/crates/hero_router`
referenced by workspace at `.../hero_router/Cargo.toml`

Caused by:
  failed to load manifest for dependency `hero_proc_lib_ui`

Caused by:
  failed to read `/Volumes/T7/code0/hero_proc/crates/hero_proc_lib_ui/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

Hit live during a herodemo deploy on 2026-05-01 — blocks service_router install.

Fix

Use the same git-dep shape as the siblings on lines 21-26:

hero_proc_lib_ui = { git = "https://forge.ourworld.tf/lhumina_code/hero_proc.git", branch = "development", version = "0.5.0" }

That matches hero_proc_sdk on the line right above. One-line change.

Hygiene notes

_archive/teststability/README.md also has /Volumes/T7 paths but those are docs and non-blocking. Worth a sweep for any other path leaks before the next release.

A simple CI guard would catch this class of bug:

grep -rn '/Volumes/' Cargo.toml crates/*/Cargo.toml && exit 1 || exit 0

Run as a pre-merge check on every PR to development. Same shape would catch /Users/ path leaks too. Worth adding to other repos as well.

## Summary [`Cargo.toml:25`](https://forge.ourworld.tf/lhumina_code/hero_router/src/branch/development/Cargo.toml#L25) in `[workspace.dependencies]` hardcodes a macOS dev path that doesn't exist on any other machine: ```toml hero_proc_lib_ui = { path = "/Volumes/T7/code0/hero_proc/crates/hero_proc_lib_ui", version = "0.5.0" } ``` Build fails for anyone not on that laptop: ``` error: failed to load manifest for workspace member `.../hero_router/crates/hero_router` referenced by workspace at `.../hero_router/Cargo.toml` Caused by: failed to load manifest for dependency `hero_proc_lib_ui` Caused by: failed to read `/Volumes/T7/code0/hero_proc/crates/hero_proc_lib_ui/Cargo.toml` Caused by: No such file or directory (os error 2) ``` Hit live during a herodemo deploy on 2026-05-01 — blocks `service_router install`. ## Fix Use the same git-dep shape as the siblings on lines 21-26: ```toml hero_proc_lib_ui = { git = "https://forge.ourworld.tf/lhumina_code/hero_proc.git", branch = "development", version = "0.5.0" } ``` That matches `hero_proc_sdk` on the line right above. One-line change. ## Hygiene notes `_archive/teststability/README.md` also has `/Volumes/T7` paths but those are docs and non-blocking. Worth a sweep for any other path leaks before the next release. A simple CI guard would catch this class of bug: ``` grep -rn '/Volumes/' Cargo.toml crates/*/Cargo.toml && exit 1 || exit 0 ``` Run as a pre-merge check on every PR to `development`. Same shape would catch `/Users/` path leaks too. Worth adding to other repos as well.