lhumina_code/hero_osis
2
0
Fork 0
Code Issues 9 Pull requests 1 Projects Releases 2 Packages Wiki Activity Actions

ci(build.yaml): update release-bin assertion hero_osis_ui → hero_osis_admin #50

Merged
mik-tf merged 1 commit from development_mik_ci_admin_rename_fix into development 2026-05-09 12:07:50 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
mik-tf commented 2026-05-09 12:07:09 +00:00
Owner
Copy link

Phase 1 carry-forward for the _ui → _admin rename in #49 — that PR flipped package.name + crate dir but missed the workflow's hardcoded BIN allowlist, so build.yaml's release-bin existence loop fails post-rename looking for target/release/hero_osis_ui.

Tracked under lhumina_code/home#230 (Phase 1).

Signed-off-by: mik-tf

Phase 1 carry-forward for the _ui → _admin rename in https://forge.ourworld.tf/lhumina_code/hero_osis/pulls/49 — that PR flipped [[package]].name + crate dir but missed the workflow's hardcoded BIN allowlist, so build.yaml's release-bin existence loop fails post-rename looking for target/release/hero_osis_ui. Tracked under https://forge.ourworld.tf/lhumina_code/home/issues/230 (Phase 1). Signed-off-by: mik-tf
ci(build.yaml): update release-bin assertion hero_osis_ui → hero_osis_admin
Some checks failed
Build Linux / build-linux (x86_64-unknown-linux-musl, false, x86_64-unknown-linux-musl) (push) Failing after 3s
Details
Build Linux / build-linux (x86_64-unknown-linux-musl, false, x86_64-unknown-linux-musl) (pull_request) Failing after 7s
Details
Build and Test / build (push) Successful in 7m12s
Details
Build and Test / build (pull_request) Successful in 8m10s
Details
321350a0d5 
Phase 1 carry-forward for the _ui → _admin rename landed in
#49 — that PR
flipped [package].name + crate dir but missed the workflow's
hardcoded BIN allowlist, so build.yaml's release-bin existence loop
fails post-rename looking for target/release/hero_osis_ui.

Tracked under lhumina_code/home#230 (Phase 1).

Signed-off-by: mik-tf
mik-tf merged commit 99fe18403f into development 2026-05-09 12:07:50 +00:00
mik-tf deleted branch development_mik_ci_admin_rename_fix 2026-05-09 12:07:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_osis!50
No description provided.