lhumina_code/hero_os_tfgrid_deployer
0
0
Fork 0
Code Issues 13 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Admin destructive actions use browser-native confirm() instead of Bootstrap modal #16

New issue
Closed
opened 2026-05-27 15:20:43 +00:00 by mik-tf · 1 comment
mik-tf commented 2026-05-27 15:20:43 +00:00
Owner
Copy link

In crates/hero_tfgrid_deployer_admin/templates/user_detail.html, the Regenerate password / Destroy VM / Delete user forms use a <form onsubmit="return confirm(...)"> pattern. Renders as the browser-native modal that says "hcockpit.gent01.qa.grid.tf says…", which:

  • Looks like a phishing dialog rather than an admin action.
  • Is not themable (light/dark mismatch on dark dashboards).
  • Breaks the visual consistency of the rest of the Bootstrap UI.

Fix shape: replace with a Bootstrap modal (or inline reveal) per the hero_ui_dashboard_admin design conventions. Pattern is already used elsewhere in Hero admin UIs.

Surfaces affected on this template:

  • Destroy VM button (vms table action).
  • Regenerate password button.
  • Delete user button.

Surfaced during s169 e2e admin walk (home#238).

In `crates/hero_tfgrid_deployer_admin/templates/user_detail.html`, the Regenerate password / Destroy VM / Delete user forms use a `<form onsubmit="return confirm(...)">` pattern. Renders as the browser-native modal that says "hcockpit.gent01.qa.grid.tf says…", which: - Looks like a phishing dialog rather than an admin action. - Is not themable (light/dark mismatch on dark dashboards). - Breaks the visual consistency of the rest of the Bootstrap UI. Fix shape: replace with a Bootstrap modal (or inline reveal) per the `hero_ui_dashboard_admin` design conventions. Pattern is already used elsewhere in Hero admin UIs. Surfaces affected on this template: - Destroy VM button (vms table action). - Regenerate password button. - Delete user button. Surfaced during s169 e2e admin walk (home#238).
mik-tf commented 2026-05-27 15:50:11 +00:00
Author
Owner
Copy link

Fixed by squash-merge c649d76 on development. Destroy / Regenerate / Delete buttons on user_detail.html now open Bootstrap modal dialogs. Live verification queued for s170 redeploy.

Fixed by squash-merge `c649d76` on `development`. Destroy / Regenerate / Delete buttons on user_detail.html now open Bootstrap modal dialogs. Live verification queued for s170 redeploy.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
development
integration
latest
dev
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_os_tfgrid_deployer#16
No description provided.