lhumina_code/hero_os_tfgrid_deployer
0
0
Fork 0
Code Issues 13 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Admin Provision form: default Node SID should fall back to core/TFGRID_NODE_IDS #15

New issue
Closed
opened 2026-05-27 15:14:28 +00:00 by mik-tf · 1 comment
mik-tf commented 2026-05-27 15:14:28 +00:00
Owner
Copy link

crates/hero_tfgrid_deployer_admin/src/routes.rs:60-62:

fn default_node_sid() -> String {
    std::env::var("DEPLOYER_DEFAULT_NODE_SID").unwrap_or_default()
}

The help text under the Node SID input on the Provision form reads "Defaults from core/TFGRID_NODE_IDS if set." but the helper only checks DEPLOYER_DEFAULT_NODE_SID. On VM 0069 only core/TFGRID_NODE_IDS=5 is set (in the hero_proc secret store), so the field is empty and the admin has to type the node sid manually.

Two fix shapes, either works:

  • Operational: set DEPLOYER_DEFAULT_NODE_SID=005d in the hero_proc secret store on every admin VM. Document in admin-vm-deployment-runbook.md. No code change. Mismatched help text needs updating either way.
  • Code: keep the env hook, add a fallback that looks up core/TFGRID_NODE_IDS from hero_proc secrets and translates the numeric grid node id to the local 4-char sid by asking the colocated compute daemon. Closer to what the help text claims and what an operator would expect, but requires the compute daemon to be reachable (blocked today by hero_os_tfgrid_deployer#13).

Either way, the help text and the helper should agree.

`crates/hero_tfgrid_deployer_admin/src/routes.rs:60-62`: ```rust fn default_node_sid() -> String { std::env::var("DEPLOYER_DEFAULT_NODE_SID").unwrap_or_default() } ``` The help text under the Node SID input on the Provision form reads "Defaults from `core/TFGRID_NODE_IDS` if set." but the helper only checks `DEPLOYER_DEFAULT_NODE_SID`. On VM 0069 only `core/TFGRID_NODE_IDS=5` is set (in the hero_proc secret store), so the field is empty and the admin has to type the node sid manually. Two fix shapes, either works: - Operational: set `DEPLOYER_DEFAULT_NODE_SID=005d` in the hero_proc secret store on every admin VM. Document in admin-vm-deployment-runbook.md. No code change. Mismatched help text needs updating either way. - Code: keep the env hook, add a fallback that looks up `core/TFGRID_NODE_IDS` from hero_proc secrets and translates the numeric grid node id to the local 4-char sid by asking the colocated compute daemon. Closer to what the help text claims and what an operator would expect, but requires the compute daemon to be reachable (blocked today by hero_os_tfgrid_deployer#13). Either way, the help text and the helper should agree.
mik-tf commented 2026-05-27 15:50:07 +00:00
Author
Owner
Copy link

Fixed by squash-merge c649d76 on development — help text under the Node SID input now matches reality (reads DEPLOYER_DEFAULT_NODE_SID env). Operationally also set DEPLOYER_DEFAULT_NODE_SID=005d on VM 0069 via hero_proc secret. The canonical hero_proc-secret-driven helper refactor (so other admins do not need to hand-edit env) is left as a follow-up.

Fixed by squash-merge `c649d76` on `development` — help text under the Node SID input now matches reality (reads `DEPLOYER_DEFAULT_NODE_SID` env). Operationally also set `DEPLOYER_DEFAULT_NODE_SID=005d` on VM `0069` via hero_proc secret. The canonical hero_proc-secret-driven helper refactor (so other admins do not need to hand-edit env) is left as a follow-up.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
development
integration
latest
dev
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_os_tfgrid_deployer#15
No description provided.