refactor: drop orphan references to disabled islands (#36) #55

Merged

timur merged 1 commit from 36-orphan-island-cfgs into development

2026-04-15 13:09:01 +00:00

timur commented

2026-04-15 13:08:59 +00:00

Owner

Third slice on #36. cargo check -p hero_os_app surfaced three unexpected_cfgs warnings — all references to features that don't exist in Cargo.toml.

island-intelligence and island-knowledge: commented out in Cargo.toml after hero_osis_sdk removed the embedder domain (382d2bf, fe880f2). Source still carried #[cfg(feature = "island-intelligence")] / island-knowledge gates — permanently-false dead code.
island-indexer-native: never existed. Only island-indexer is a real feature; the not(feature = "island-indexer-native") clause was always true.

Changes

island_content.rs: drop pub use IntelligenceIslandApp / KnowledgeIslandApp and their rsx match arms; simplify the indexer cfg.
registry.rs: drop intelligence_metadata / knowledge_metadata imports and their v.push(...) calls.
Cargo.toml: remove the two commented-out # island-… feature lines; rewrite the web = [...] NOTE to reflect the current state, not a stale "temporarily excluded" story.

Verification

cargo check -p hero_os_app: warnings drop from 22 → 13 (all three bogus-cfg warnings gone).
cargo check --workspace: OK.

Refs #36.

🤖 Generated with Claude Code

Third slice on #36. `cargo check -p hero_os_app` surfaced three `unexpected_cfgs` warnings — all references to features that don't exist in `Cargo.toml`. - `island-intelligence` and `island-knowledge`: commented out in Cargo.toml after `hero_osis_sdk` removed the `embedder` domain (382d2bf, fe880f2). Source still carried `#[cfg(feature = "island-intelligence")]` / `island-knowledge` gates — permanently-false dead code. - `island-indexer-native`: never existed. Only `island-indexer` is a real feature; the `not(feature = "island-indexer-native")` clause was always true. ## Changes - `island_content.rs`: drop `pub use IntelligenceIslandApp` / `KnowledgeIslandApp` and their rsx match arms; simplify the indexer cfg. - `registry.rs`: drop `intelligence_metadata` / `knowledge_metadata` imports and their `v.push(...)` calls. - `Cargo.toml`: remove the two commented-out `# island-…` feature lines; rewrite the `web = [...]` NOTE to reflect the current state, not a stale "temporarily excluded" story. ## Verification - `cargo check -p hero_os_app`: warnings drop from **22 → 13** (all three bogus-cfg warnings gone). - `cargo check --workspace`: OK. Refs #36. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

timur added 1 commit

2026-04-15 13:08:59 +00:00

refactor: drop orphan references to disabled islands (#36 )

Build and Test / test (pull_request) Failing after 25s

Details

894d9dcf4c

`island-intelligence`, `island-knowledge`, and `island-indexer-native`
are not real features — the first two are commented out in Cargo.toml
(hero_osis_sdk removed the embedder domain); the third never existed.
The remaining `#[cfg(feature = "…")]` gates on these names were
permanently-false dead code, producing `unexpected_cfgs` warnings on
every build.

- island_content.rs: remove `pub use IntelligenceIslandApp` /
  `KnowledgeIslandApp`, their rsx match arms, and the bogus
  `not(feature = "island-indexer-native")` clause on the indexer cfg.
- registry.rs: remove `intelligence_metadata` / `knowledge_metadata`
  imports and the corresponding `v.push(...)` calls.
- Cargo.toml: drop the two commented-out `# island-…` feature lines
  (git history is the archive) and rewrite the `web = [...]` NOTE to
  reflect the final state rather than a "temporarily excluded" state.

Re-enabling any of these islands later is a one-line change in the
upstream archipelagos crate + a feature re-add here.

Refs #36.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

timur merged commit 6aedaa8680 into development

2026-04-15 13:09:01 +00:00

timur referenced this pull request from a commit

2026-04-15 13:09:03 +00:00

refactor: drop orphan references to disabled islands (#36) (#55)

timur referenced this pull request

2026-04-15 15:33:21 +00:00

Cleanup: dead code, competing impls, and refactor debris audit #36