rpc surface not migrated to canonical hero_sockets routes (legacy-only)

mahmoud commented

2026-06-16 11:45:10 +00:00

Owner

Summary

hero_livekit's rpc socket has not been migrated to the canonical hero_sockets.md route surface. It hand-rolls only the legacy / pre-migration endpoints (/health, /.well-known/heroservice.json, /rpc, /openrpc.json) and serves none of the canonical endpoints, so hero_router's Diagnostics → Spec compliance probe reports it Non-compliant.

Canonical surface required (`hero_sockets.md`)

On rpc.sock:

GET /health.json
GET /heroservice.json
GET /api/domains.json
GET /api/ping → "pong"
GET /api/{domain}/openrpc.json
POST /api/{domain}/rpc

Current state

Serves only the legacy set (/health, /.well-known/heroservice.json, /rpc, /openrpc.json); all canonical paths return 404.
Hand-rolled router: crates/hero_livekit_backend/src/main.rs.

curl --unix-socket ~/hero/var/sockets/hero_livekit/rpc.sock http://localhost/health.json   # → 404 (expect 200)
curl --unix-socket ~/hero/var/sockets/hero_livekit/rpc.sock http://localhost/api/ping       # → 404 (expect 200 "pong")

Fix

Stop hand-rolling the rpc surface; mount the shared hero_lib canonical router so the full surface (incl. /api/ping) comes for free and can't drift:

hero_lifecycle::rpc::mandatory_router(...) / service_root_router(...), or
the generated oschema_server build_router(...).

Compliant services (hero_proc, hero_code, hero_router) already do this. hero_browser was the minimal-fix counter-example (commit c6f5abe just added the missing /api/ping); a full migration is preferred here since the whole surface is absent.

Verify

Each canonical path returns 200 over the rpc socket, and the service's Diagnostics tab in hero_router reports compliant (required_fail: 0).

## Summary `hero_livekit`'s rpc socket has **not been migrated to the canonical `hero_sockets.md` route surface**. It hand-rolls only the legacy / pre-migration endpoints (`/health`, `/.well-known/heroservice.json`, `/rpc`, `/openrpc.json`) and serves **none** of the canonical endpoints, so hero_router's **Diagnostics → Spec compliance probe** reports it Non-compliant. ## Canonical surface required (`hero_sockets.md`) On `rpc.sock`: - `GET /health.json` - `GET /heroservice.json` - `GET /api/domains.json` - `GET /api/ping` → `"pong"` - `GET /api/{domain}/openrpc.json` - `POST /api/{domain}/rpc` ## Current state Serves only the legacy set (`/health`, `/.well-known/heroservice.json`, `/rpc`, `/openrpc.json`); all canonical paths return `404`. Hand-rolled router: `crates/hero_livekit_backend/src/main.rs`. ```bash curl --unix-socket ~/hero/var/sockets/hero_livekit/rpc.sock http://localhost/health.json # → 404 (expect 200) curl --unix-socket ~/hero/var/sockets/hero_livekit/rpc.sock http://localhost/api/ping # → 404 (expect 200 "pong") ``` ## Fix Stop hand-rolling the rpc surface; mount the shared hero_lib canonical router so the full surface (incl. `/api/ping`) comes for free and can't drift: - `hero_lifecycle::rpc::mandatory_router(...)` / `service_root_router(...)`, or - the generated `oschema_server` `build_router(...)`. Compliant services (hero_proc, hero_code, hero_router) already do this. hero_browser was the minimal-fix counter-example (commit `c6f5abe` just added the missing `/api/ping`); a full migration is preferred here since the whole surface is absent. ## Verify Each canonical path returns `200` over the rpc socket, and the service's **Diagnostics** tab in hero_router reports compliant (`required_fail: 0`).

sameh-farouk referenced this issue

2026-06-16 12:01:18 +00:00

hero_livekit: hero_proc doesn't inject LIVEKIT_VERSION -> SFU never launches (nothing binds :7880) #50

sameh-farouk commented

2026-06-16 12:19:49 +00:00

Member

Coordination: I am taking the full hero_livekit canonical-surface migration on development (decided with Sameh). It resolves this issue (server surface → canonical router) and the connectivity half of #50 (client calls to hero_proc move off the dead legacy /rpc to /api/secrets/rpc). The two are the same root cause (hero_livekit still on the frozen pre-migration stack), so a single migration covers both.

Sequencing: queued right after I close out some in-flight hero_collab issues; starting on it next. @mahmoud — to avoid duplicate work, are you mid-implementation on this? If so let's split/coordinate; otherwise I'll own it and credit your diagnosis here. Your "mount the shared canonical router / oschema_server" direction is exactly the plan.

**Coordination:** I am taking the full hero_livekit canonical-surface migration on `development` (decided with Sameh). It resolves this issue (server surface → canonical router) **and** the connectivity half of #50 (client calls to hero_proc move off the dead legacy `/rpc` to `/api/secrets/rpc`). The two are the same root cause (hero_livekit still on the frozen pre-migration stack), so a single migration covers both. Sequencing: queued right after I close out some in-flight hero_collab issues; starting on it next. @mahmoud — to avoid duplicate work, are you mid-implementation on this? If so let's split/coordinate; otherwise I'll own it and credit your diagnosis here. Your "mount the shared canonical router / oschema_server" direction is exactly the plan.

sameh-farouk referenced this issue

2026-06-16 12:19:58 +00:00

hero_livekit: hero_proc doesn't inject LIVEKIT_VERSION -> SFU never launches (nothing binds :7880) #50

sameh-farouk self-assigned this

2026-06-16 12:21:11 +00:00

sameh-farouk referenced this issue from a commit

2026-06-16 16:00:15 +00:00

docs(livekit): turnkey plan for canonical herolib serving migration (#50/#51)

sameh-farouk commented

2026-06-16 16:03:52 +00:00

Member

Migration plan written (turnkey): hero_livekit/docs/superpowers/plans/2026-06-16-livekit-canonical-migration.md on branch development_sameh_livekit_migration. Target = canonical herolib serving (herolib_macros::openrpc_server! + serve_domains), like hero_collab/hero_proc — NOT the stale livekit_migration hero_rpc approach. The oschema already has a service LiveKitService { } block (close to the collab pattern). Remaining: deps flip (osis_oldserving→herolib@development), main.rs rewrite (drop rpc2_adapter/OsisLivekit), provision port (fold #50 hardening from development_sameh_livekit50 f30c9b6), SDK/admin canonical updates, box verify. SFU runs meanwhile via manual LiveKitService.start (survives until hero_livekit_server restart). Collab regression sweep (the blocker) is DONE+merged; livekit migration is the focused next push.

**Migration plan written** (turnkey): `hero_livekit/docs/superpowers/plans/2026-06-16-livekit-canonical-migration.md` on branch `development_sameh_livekit_migration`. Target = canonical **herolib** serving (`herolib_macros::openrpc_server!` + serve_domains), like hero_collab/hero_proc — NOT the stale `livekit_migration` hero_rpc approach. The oschema already has a `service LiveKitService { }` block (close to the collab pattern). Remaining: deps flip (osis_oldserving→herolib@development), main.rs rewrite (drop rpc2_adapter/OsisLivekit), provision port (fold #50 hardening from `development_sameh_livekit50` f30c9b6), SDK/admin canonical updates, box verify. SFU runs meanwhile via manual `LiveKitService.start` (survives until hero_livekit_server restart). Collab regression sweep (the blocker) is DONE+merged; livekit migration is the focused next push.

sameh-farouk referenced this issue from a commit

2026-06-16 18:37:56 +00:00

wip(livekit): herolib migration (subagent output, pre-review/verify) [#50 #51]

sameh-farouk referenced this issue from a commit

2026-06-16 18:56:24 +00:00

fix(livekit): reconcile migration against herolib@development APIs [#50 #51]

sameh-farouk referenced this issue from a commit

2026-06-16 19:04:48 +00:00

fix(livekit): reconcile rhai bindings + examples with regenerated SDK [#50 #51]

sameh-farouk referenced this issue from a commit

2026-06-16 19:57:08 +00:00

feat(livekit): migrate to canonical herolib serving (#50, #51)

sameh-farouk closed this issue

2026-06-16 19:57:09 +00:00

sameh-farouk commented

2026-06-16 21:52:22 +00:00

Member

Fixed + closed in 63f80f5 (development) — hero_livekit migrated off the frozen osis_oldserving (hero_rpc2/OSIS) stack to the canonical herolib serving (herolib_macros::openrpc_server! + serve_domains), like hero_collab/hero_proc.

It now serves the full canonical hero_sockets surface on rpc.sock; legacy /rpc is gone (404).

Verified on box: GET /api/ping → "pong"; GET /api/domains.json → {main}; GET /heroservice.json → 200; POST /api/main/rpc (bare method names, e.g. status) works; and the hero_router dashboard discovers the service with its 12-method surface (Diagnostics no longer legacy-only). Thanks @mahmoud for the diagnosis.

**Fixed + closed** in `63f80f5` (development) — hero_livekit migrated off the frozen `osis_oldserving` (hero_rpc2/OSIS) stack to the canonical **herolib** serving (`herolib_macros::openrpc_server!` + `serve_domains`), like hero_collab/hero_proc. It now serves the full canonical hero_sockets surface on rpc.sock; legacy `/rpc` is gone (404). **Verified on box:** `GET /api/ping` → `"pong"`; `GET /api/domains.json` → `{main}`; `GET /heroservice.json` → 200; `POST /api/main/rpc` (bare method names, e.g. `status`) works; and the **hero_router dashboard discovers the service with its 12-method surface** (Diagnostics no longer legacy-only). Thanks @mahmoud for the diagnosis.

Rows
Columns

rpc surface not migrated to canonical hero_sockets routes (legacy-only) #51

Summary

Canonical surface required (hero_sockets.md)

Current state

Fix

Verify

Canonical surface required (`hero_sockets.md`)