fix(core_rhai): align redis dep with herolib_core 0.6.0 (0.31 → 1)

mik-tf commented

2026-05-09 04:37:30 +00:00

Owner

Upstream herolib_core (hero_lib 99aa2bb8, May 8) bumped redis 0.31 → 1.x. core_rhai held at 0.31, producing two redis versions in the dep graph + 21 type-mismatch errors at the herolib_core::redis_client_mod::execute boundary. Side fix: redis::Value is #[non_exhaustive] in 1.x — added _ => UNIT arm. Verified: hero_builder 5/5 binaries built (hero_do, hero_runner_rhai, hero_runner_rhai_server, hero_runner_rhai_admin, gpu_agent). Resolves s81 Class D: lhumina_code/home#230 (comment).

Upstream herolib_core (hero_lib 99aa2bb8, May 8) bumped redis 0.31 → 1.x. core_rhai held at 0.31, producing two redis versions in the dep graph + 21 type-mismatch errors at the herolib_core::redis_client_mod::execute boundary. Side fix: redis::Value is #[non_exhaustive] in 1.x — added _ => UNIT arm. Verified: hero_builder 5/5 binaries built (hero_do, hero_runner_rhai, hero_runner_rhai_server, hero_runner_rhai_admin, gpu_agent). Resolves s81 Class D: https://forge.ourworld.tf/lhumina_code/home/issues/230#issuecomment-31194.

mik-tf added 1 commit

2026-05-09 04:37:30 +00:00

fix(core_rhai): align redis dep with herolib_core 0.6.0 (0.31 → 1)

Lint / lint-linux (pull_request) Failing after 4s

Details

Tests / test-linux (pull_request) Failing after 23s

Details

70490aa50f

upstream herolib_core (hero_lib commit 99aa2bb8) bumped redis 0.31 → 1.x
as part of the canonical-version pass. core_rhai's local pin held it at
0.31, producing two redis crate versions in the dep graph and 21
type-mismatch errors at the herolib_core::redis_client_mod::execute
boundary. Match herolib_core's pin.

Side fix: redis::Value is #[non_exhaustive] in 1.x. Add a `_ => UNIT`
wildcard arm to redis_value_to_dynamic so the match compiles. The 14
explicit arms cover every variant 1.2.1 currently exposes.

Verified via hero_builder --release --install: 5/5 binaries built (hero_do,
hero_runner_rhai, hero_runner_rhai_server, hero_runner_rhai_admin, gpu_agent).

Resolves the s81 Class D carry-over: lhumina_code/home#230 (comment)

Signed-off-by: mik-tf

mik-tf merged commit 305ffe2a08 into development

2026-05-09 04:38:32 +00:00

mik-tf deleted branch development_mik_redis1_align

2026-05-09 04:38:33 +00:00

mik-tf referenced this pull request from a commit

2026-05-09 04:38:33 +00:00

fix(core_rhai): align redis dep with herolib_core 0.6.0 (0.31 → 1) (#23)

mik-tf referenced this pull request from lhumina_code/home

2026-05-09 12:15:03 +00:00

[META] Post-s77 skill alignment audit — naming completion (4 repos), BASE_PATH purge, CI verification, fresh-VM re-validation #230

Rows
Columns

fix(core_rhai): align redis dep with herolib_core 0.6.0 (0.31 → 1) #23