ci(release): rustup target add x86_64-unknown-linux-musl + workspace fmt #17
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_lib_rhai!17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "development_mik_home212_lib_rhai_musl_target"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs lhumina_code/home#212
Fix-forward on PRs #14 / #15. Bundles two CI greens that both need to land before this repo can ship.
Commits
ci(release): explicit rustup target add for x86_64-unknown-linux-musl— v0.1.0-rc2 build-linux failed in 25s onerror[E0463]: can't find crate for core.scripts/build_lib.sh::setup_linux_toolchain()(line 1171) explicitly skipsrustup target addwhen target isx86_64-unknown-linux-musl, assuming it's pre-installed onghcr.io/despiegk/builder:latest. It isn't. Sibling workflows (hero_voice, hero_editor) target*-gnuonly, so the latent bug never surfaced; hero_proc inlines its own toolchain step. One extra idempotent line in the workflow's Setup toolchain step does it.style: cargo fmt across hero_runner_rhai* crates—lint-linuxhas been failing ondevelopmentfor at least 5 runs withcargo fmt --checkdiff across 16 files incrates/hero_runner_rhai{,_server,_ui}. Pure mechanical drift, no behaviour change. With this in place, the lint workflow'scargo fmt --checkreturns clean.Splitting these would leave one CI job red until the second PR merged — bundling avoids the half-red intermediate state. Net diff is small for review purposes (the +219/-150 fmt diff is mechanical, the +2 line workflow change is the substantive bit).
After merge
Tag
v0.1.0-rc3(rc2 already taken at the rev-pin commit; rc3 is the next free rc number). CI should then publish 4 release assets:Consumer PR lhumina_code/hero_skills#221 lands once the assets exist.
Signed-off-by: mik-tf
rustup target addfor x86_64-unknown-linux-musl`lint-linux` has been failing on `development` with `cargo fmt --check` diff for at least the last 5 runs (all pre-dating this session). 16 files in `crates/hero_runner_rhai{,_server,_ui}` had unformatted code — pure mechanical drift, no behaviour change. Result of `cargo fmt --all`. With this in place, the canonical fmt-check command from the workflow source scripts/build_lib.sh 2>/dev/null && cargo_env && cargo fmt --check returns clean. Bundled with the rustup-target fix in this PR because both have to land before lint-linux + build-linux can both go green; splitting would just leave one of them red until the second PR merges. Refs lhumina_code/home#212 Signed-off-by: mik-tfci(release): explicit rustup target add for x86_64-unknown-linux-muslto ci(release): rustup target add x86_64-unknown-linux-musl + workspace fmt#[allow(dead_code)]on fetch_content,while letloop in worker`make lint` runs `cargo fmt --check` AND `cargo clippy --workspace -- -D warnings`. The fmt commit on this branch greens the first; this commit greens the second. Two clippy errors: 1. `crates/hero_runner_rhai_server/src/resolver.rs:191` — function `fetch_content` is never used. The hero_do crate has its own copy that is used; this one is plausibly future-wiring (the comment above marks it as a `run()` helper). Adding `#[allow(dead_code)]` keeps it for that future use without blocking lint today. 2. `crates/hero_runner_rhai_server/src/worker.rs:37` — `loop { match { Ok => …, Err => break } }` rewritten as `while let Ok(req) = read_msg::<ScriptRequest>(&stream)`. Mechanically equivalent; parent closing the socket still exits the loop. `read_msg` is generic over `DeserializeOwned`, so the turbofish keeps the `ScriptRequest` type binding the original `let req: ScriptRequest` pattern carried. `cargo clippy --workspace -- -D warnings` now finishes clean. Refs lhumina_code/home#212 Signed-off-by: mik-tfMISSING: hero_proctooling-check (pre-existing) #18