lhumina_code/hero_lib
10
0
Fork 1
Code Issues 23 Pull requests Projects Releases 3 Packages 1 Wiki Activity Actions

deprecate(core): mark service-authoring API as moved to hero_lifecycle::base #146

Merged
timur merged 1 commit from development_1 into development 2026-05-26 09:32:40 +00:00
Conversation 0 Commits 1 Files changed 1 +33
timur commented 2026-05-26 09:32:18 +00:00
Owner
Copy link

Summary

  • Add #[deprecated] attributes to the service-authoring pub use statements in crates/core/src/base/mod.rs (ServiceToml + closed enums, validate_service_toml, handle_info_flag, print_startup_banner, prepare_sockets, socket resolvers, SocketPrep).
  • Note text points consumers at hero_lifecycle::base and references hero_rpc#142.
  • Suppress the deprecation warning inside the service_base!() macro expansion (#[allow(deprecated)] on the internal call) so the macro itself still works without forcing every existing call site to wear a #[allow(deprecated)] until they migrate. The pub use is still deprecated, so any direct herolib_core::base::X import surfaces the warning.
  • paths.rs re-exports untouched — those are lab-specific path helpers, not service-authoring primitives.

Test plan

  • cargo build --workspace clean (no warnings on internal hero_lib code).
  • Implementations in crates/core/src/base/service.rs unchanged — no behaviour change; downstream consumers keep compiling, just see warnings.

#145

## Summary - Add `#[deprecated]` attributes to the service-authoring `pub use` statements in `crates/core/src/base/mod.rs` (`ServiceToml` + closed enums, `validate_service_toml`, `handle_info_flag`, `print_startup_banner`, `prepare_sockets`, socket resolvers, `SocketPrep`). - Note text points consumers at `hero_lifecycle::base` and references hero_rpc#142. - Suppress the deprecation warning inside the `service_base!()` macro expansion (`#[allow(deprecated)]` on the internal call) so the macro itself still works without forcing every existing call site to wear a `#[allow(deprecated)]` until they migrate. The `pub use` is still deprecated, so any direct `herolib_core::base::X` import surfaces the warning. - `paths.rs` re-exports untouched — those are lab-specific path helpers, not service-authoring primitives. ## Test plan - `cargo build --workspace` clean (no warnings on internal hero_lib code). - Implementations in `crates/core/src/base/service.rs` unchanged — no behaviour change; downstream consumers keep compiling, just see warnings. https://forge.ourworld.tf/lhumina_code/hero_lib/issues/145
deprecate(core): mark service-authoring API as moved to hero_lifecycle::base
Some checks failed
Lint / lint-linux (pull_request) Successful in 34s
Details
Tests with Services / test-linux (pull_request) Failing after 11m33s
Details
7bfb850653
 
#145
timur merged commit 5cfc08d8a2 into development 2026-05-26 09:32:40 +00:00
timur deleted branch development_1 2026-05-26 09:32:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_lib!146
No description provided.