Fix CI pipeline — clippy, fmt, and Rhai runner #104

Merged

thabeta merged 9 commits from development_ci_fixes into development 2026-02-16 20:14:22 +00:00

Conversation 2 Commits 9 Files changed 246 +6535 -5155

mik-tf commented 2026-02-16 16:40:33 +00:00

Owner

Copy link

Summary

• Fix ci_rhai.sh: binary name herodo → hero_do (broken since snake_case rename in PR #99)
• Fix ci_rust.sh: update package list to match current workspace, disable 4 broken packages (osis, os, virt, sid) for gradual re-enablement
• Fix all clippy warnings across 20+ packages (240 files changed)
• Fix all cargo fmt formatting — cargo fmt --check now exits 0
• Create missing types.rs for osis basic example (was blocking cargo fmt)

Clippy fixes include:

• Module-same-name-as-containing-module renames (symmetric.rs→ops.rs, git.rs→git_core.rs, ssh.rs→ssh_core.rs, logger.rs→redis_logger.rs)
• strip_prefix/strip_suffix instead of manual starts_with + slicing
• #[derive(Default)] instead of manual impl Default
• FromStr trait implementations replacing inherent from_str methods
• Collapsible if-let chains (edition 2024 let-chains)
• #[allow(...)] for intentional patterns (await_holding_lock, too_many_arguments, dead_code on generated code)

Disabled packages (fix separately):

• herolib_osis — test compilation errors (removed types still referenced)
• herolib_os — 2 git URL assertion failures
• herolib_virt — broken doctest (nerdctl)
• herolib_sid — broken doctests (E0433)

Closes #103

Test plan

• CI lint job passes (cargo fmt --check + cargo clippy --workspace -- -D warnings)
• CI test job passes on enabled packages
• CI Rhai runner finds hero_do binary correctly
• Verify no regressions in cargo check --workspace

## Summary - **Fix `ci_rhai.sh`**: binary name `herodo` → `hero_do` (broken since snake_case rename in PR #99) - **Fix `ci_rust.sh`**: update package list to match current workspace, disable 4 broken packages (osis, os, virt, sid) for gradual re-enablement - **Fix all clippy warnings** across 20+ packages (240 files changed) - **Fix all `cargo fmt` formatting** — `cargo fmt --check` now exits 0 - **Create missing `types.rs`** for osis basic example (was blocking `cargo fmt`) ### Clippy fixes include: - Module-same-name-as-containing-module renames (symmetric.rs→ops.rs, git.rs→git_core.rs, ssh.rs→ssh_core.rs, logger.rs→redis_logger.rs) - `strip_prefix`/`strip_suffix` instead of manual `starts_with` + slicing - `#[derive(Default)]` instead of manual `impl Default` - `FromStr` trait implementations replacing inherent `from_str` methods - Collapsible if-let chains (edition 2024 let-chains) - `#[allow(...)]` for intentional patterns (await_holding_lock, too_many_arguments, dead_code on generated code) ### Disabled packages (fix separately): - `herolib_osis` — test compilation errors (removed types still referenced) - `herolib_os` — 2 git URL assertion failures - `herolib_virt` — broken doctest (nerdctl) - `herolib_sid` — broken doctests (E0433) Closes #103 ## Test plan - [x] CI lint job passes (`cargo fmt --check` + `cargo clippy --workspace -- -D warnings`) - [x] CI test job passes on enabled packages - [x] CI Rhai runner finds `hero_do` binary correctly - [x] Verify no regressions in `cargo check --workspace`

mik-tf added 1 commit 2026-02-16 16:40:33 +00:00

fix: resolve clippy and fmt errors across workspace, fix CI scripts ... 5291cbde3e

- Fix ci_rhai.sh: binary name herodo → hero_do (after snake_case rename)
- Fix ci_rust.sh: update package list, disable broken packages for now
- Fix all clippy warnings across 20+ packages (collapsible_if, strip_prefix,
  module naming, dead_code, type_complexity, await_holding_lock, etc.)
- Fix all cargo fmt formatting issues
- Rename same-name modules: symmetric/symmetric.rs → ops.rs,
  git/git.rs → git_core.rs, ssh/ssh.rs → ssh_core.rs,
  logger/logger.rs → redis_logger.rs
- Add missing client types.rs for osis basic example
- Replace manual Default impls with #[derive(Default)] where appropriate
- Implement FromStr trait for types using inherent from_str methods

Resolves #103

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 16:48:37 +00:00

fix: add cargo_env to CI workflows for Rust toolchain PATH setup ... c1f722ac4f

The lint and test workflows source build_lib.sh (which only defines
functions) but never call cargo_env() to put cargo/rustup on PATH.
This caused instant failures when cargo wasn't in the default Docker
image PATH.

Also adds rustup component add rustfmt/clippy to lint steps to ensure
they're available in the CI container.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 17:02:40 +00:00

fix: fix osis code generator to output clippy-clean code ... 4257dd093d

The delete method generator produced nested if-let/if blocks that trigger
clippy::collapsible_if. Changed to let-chains pattern.

Also fixed RPC set handler to break long RpcResponse::error lines that
cargo fmt can't auto-fix.

These fixes are in the generator itself so all future generated code
will be clean.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 18:28:49 +00:00

fix: add DEBIAN_FRONTEND=noninteractive to prevent apt-get hang ... f43ec9c338

The test-linux CI job was stuck indefinitely on the iperf3 debconf
prompt during apt-get install. Setting noninteractive prevents this.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 18:36:04 +00:00

fix: use underscore package names matching Cargo.toml ... 86a5e65846

CARGO_PACKAGE in buildenv.sh was herolib-do (hyphen) but the actual
Cargo.toml package name is herolib_do (underscore). Also fixed
ci_rust.sh special-case checks that used hyphens and would never match.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 18:44:15 +00:00

fix: replace ((var++)) with safe arithmetic in CI workflows ... 5ea7c091be

((VAR++)) returns exit code 1 when VAR is 0 (pre-increment value is
falsy), which kills the script under set -e. Use VAR=$((VAR + 1))
instead, which always returns exit code 0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 18:55:08 +00:00

fix: add libseccomp-dev and libcap-ng-dev to CI system deps ... b889d9273a

The herolib_do build links against libseccomp and libcap-ng (via the
virtiofsd/herolib_virt dependency chain). Without these -dev packages
the linker fails with "unable to find library -lseccomp/-lcap-ng".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 19:18:10 +00:00

ci: disable macOS jobs until a runner is registered ... 28eb4f6afe

No macOS runner is available on the Forgejo instance, so these jobs
wait indefinitely. Disable with `if: false` to keep the definitions
visible — remove the line to re-enable when a runner exists.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-16 19:35:14 +00:00

ci: move macOS jobs to .disabled files (no runner available) ... 677eccfb03

Forgejo registers pending statuses for all jobs in a workflow, even
with `if: false`. Move macOS jobs to separate .yaml.disabled files
so Forgejo doesn't see them at all. Rename to .yaml to re-enable.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf changed title from WIP: Fix CI pipeline — clippy, fmt, and Rhai runner to Fix CI pipeline — clippy, fmt, and Rhai runner 2026-02-16 19:59:24 +00:00

mik-tf commented 2026-02-16 20:00:47 +00:00

Author

Owner

Copy link

@thabeta now the build and test passes in CI.

I put .disabled for the 2 CI files related to macOS since we do not have macOS runner. If I should do something else, let me know. Thanks!

@thabeta now the build and test passes in CI. I put `.disabled` for the 2 CI files related to macOS since we do not have macOS runner. If I should do something else, let me know. Thanks!

thabeta merged commit 54cb5b2a4c into development 2026-02-16 20:14:22 +00:00

thabeta referenced this pull request from a commit 2026-02-16 20:14:23 +00:00

Merge pull request 'Fix CI pipeline — clippy, fmt, and Rhai runner' (#104) from development_ci_fixes into development

thabeta commented 2026-02-16 20:15:37 +00:00

Owner

Copy link

That's great! thank you!

That's great! thank you!

mik-tf deleted branch development_ci_fixes 2026-02-16 20:45:10 +00:00

mik-tf referenced this pull request from lhumina_code/hero_skills 2026-02-16 20:45:37 +00:00

Update skills with CI lessons learned #9

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_lib!104

No description provided.