#28 - [ci] clippy hygiene cleanup — workspace not -D warnings clean - lhumina_code/hero_foundry

mik-tf commented

2026-05-04 21:27:16 +00:00

Owner

Context

Surfaced during Phase 2 cluster A propagation (session 56). After running the workspace pre-merge gate cargo clippy --workspace --all-targets -- -D warnings, ~30 pre-existing warnings turn into errors.

This issue mirrors hero_biz#22 which captured the same situation in session 55.

The --from-ci PR for hero_foundry deferred this to keep scope focused on the CI release pipeline. Workspace cargo build --workspace --release is green; it's the linter strictness that needs cleanup.

Acceptance

cargo clippy --workspace --all-targets -- -D warnings exits 0 on development.

Out of scope

Functional changes; the warnings are mechanical cleanup only.

## Context Surfaced during Phase 2 cluster A propagation (session 56). After running the workspace pre-merge gate `cargo clippy --workspace --all-targets -- -D warnings`, ~30 pre-existing warnings turn into errors. This issue mirrors [hero_biz#22](https://forge.ourworld.tf/lhumina_code/hero_biz/issues/22) which captured the same situation in session 55. The `--from-ci` PR for hero_foundry deferred this to keep scope focused on the CI release pipeline. Workspace `cargo build --workspace --release` is green; it's the linter strictness that needs cleanup. ## Categories - 8x `redundant_closure` — `crates/hero_foundry_web/src/routes.rs` (Vec::new() / Vec::<String>::new() in `use_signal`) - ~10x `collapsible_if` / `collapsible_else_if` — across `hero_foundry_core`, `hero_foundry_server`, `hero_foundry_ui`, `hero_foundry` - Dead code: `parse_json_listing` (webdav_client/lib.rs:689), `delete_branch_internal`/`delete_tag_internal` (core/repo/mod.rs:702), `RepoInfo` struct (web/types.rs:42), several never-read fields - `manual_is_multiple_of` — core/sync/quic.rs:625 - `unwrap_or_else` → `unwrap_or_default` — server/state.rs:278, ui/main.rs:1186 - `&String::new()` → `""` — core/repo/builders/merge.rs:471 - `unnecessary use of get(hash).is_some()` → `contains_key` — core/repo/builders/merge.rs:404 - `manual_deref` — core/sync/quic.rs:530 - `length_comparison_to_one` — server/tests/two_server_sync_tests.rs:92 - `unexpected cfg condition value: server` — server/tests/openrpc_tests.rs:10 - `merge_branches` 8-arg already addressed inline with `#[allow(clippy::too_many_arguments)]` ## Acceptance `cargo clippy --workspace --all-targets -- -D warnings` exits 0 on `development`. ## Out of scope Functional changes; the warnings are mechanical cleanup only.