bug: Deploy modal hides resource preview (RAM/Disk/vCPUs) in all non-explorer modes #79

New issue

Open

opened 2026-04-07 12:41:26 +00:00 by mahmoud · 0 comments

mahmoud commented

2026-04-07 12:41:26 +00:00

Owner

Problem

When deploying a VM in any non-explorer mode (local, master, or worker), the deploy modal hides the resource preview card (RAM, Disk, vCPUs). The user has no idea how much resources their VM will get before clicking Deploy.

This affects:

Local mode — single node operator
Master mode — deploying on the master node itself
Worker mode — worker node admin visiting their local UI at http://worker-ip:9001

All three cases have a local compute server with node data available via RPC.

Current Behavior

// dashboard.js line 1751-1754
if (isExplorerMode()) {
    // Show node selector + preview ✓
} else {
    document.getElementById("deployNodeGroup").classList.add("d-none");
    document.getElementById("deployPreview").classList.add("d-none");  // ← always hidden
}

In non-explorer mode, _deployNodeData is never populated, so updateDeployPreview() bails out.

Expected Behavior

The resource preview should always be visible, in every mode:

Number of Slices: [2]
Max 15 slices available

┌──────────┬──────────┬──────────┐
│  8 GB    │  126 GB  │  2       │
│  RAM     │  Disk    │  vCPUs   │
└──────────┴──────────┴──────────┘

Changing the slice count should update the preview in real time.

Fix

In non-explorer mode, fetch local node data via ComputeService.node_status and ComputeService.list_slices to populate _deployNodeData, then show the preview.

Node selector stays hidden (only one node)
Resource preview always visible
Max slices hint shown

Acceptance Criteria

Resource preview visible in local mode
Resource preview visible in master mode (local deploy)
Resource preview visible in worker mode (local UI)
Preview updates when slice count changes
Max slices hint based on available slices
Explorer mode behavior unchanged

## Problem When deploying a VM in **any non-explorer mode** (local, master, or worker), the deploy modal hides the resource preview card (RAM, Disk, vCPUs). The user has no idea how much resources their VM will get before clicking Deploy. This affects: - **Local mode** — single node operator - **Master mode** — deploying on the master node itself - **Worker mode** — worker node admin visiting their local UI at `http://worker-ip:9001` All three cases have a local compute server with node data available via RPC. ## Current Behavior ```javascript // dashboard.js line 1751-1754 if (isExplorerMode()) { // Show node selector + preview ✓ } else { document.getElementById("deployNodeGroup").classList.add("d-none"); document.getElementById("deployPreview").classList.add("d-none"); // ← always hidden } ``` In non-explorer mode, `_deployNodeData` is never populated, so `updateDeployPreview()` bails out. ## Expected Behavior The resource preview should **always** be visible, in every mode: ``` Number of Slices: [2] Max 15 slices available ┌──────────┬──────────┬──────────┐ │ 8 GB │ 126 GB │ 2 │ │ RAM │ Disk │ vCPUs │ └──────────┴──────────┴──────────┘ ``` Changing the slice count should update the preview in real time. ## Fix In non-explorer mode, fetch local node data via `ComputeService.node_status` and `ComputeService.list_slices` to populate `_deployNodeData`, then show the preview. - Node selector stays hidden (only one node) - Resource preview always visible - Max slices hint shown ## Acceptance Criteria - [ ] Resource preview visible in **local** mode - [ ] Resource preview visible in **master** mode (local deploy) - [ ] Resource preview visible in **worker** mode (local UI) - [ ] Preview updates when slice count changes - [ ] Max slices hint based on available slices - [ ] Explorer mode behavior unchanged

mahmoud changed title from ~~bug: Deploy modal hides resource preview (RAM/Disk/vCPUs) in local and master mode~~ to bug: Deploy modal hides resource preview (RAM/Disk/vCPUs) in all non-explorer modes

2026-04-07 12:42:52 +00:00