fix(server): drop Option<ConnectInfo> for axum 0.8 compat #26

Merged

mik-tf merged 1 commit from development_mik_axum08_handler into development

2026-05-09 04:38:31 +00:00

mik-tf commented

2026-05-09 04:37:29 +00:00

Owner

axum 0.8 dropped the blanket Option: FromRequestParts impl. ConnectInfo does not implement OptionalFromRequestParts in 0.8, so rpc_handler no longer satisfied Handler<_, _>. The server is Unix-socket-only (uses hyper::serve_connection, not serve_with_connect_info), so connect_info was always None at runtime — dead weight. Headers (x-caller-ip, x-forwarded-for) cover the TCP fallback via extract_caller_ip. Verified: hero_builder --release --install: 3/3 binaries built. Resolves s81 carry-over: lhumina_code/home#230 (comment) (Class E).

axum 0.8 dropped the blanket Option<T>: FromRequestParts impl. ConnectInfo does not implement OptionalFromRequestParts in 0.8, so rpc_handler no longer satisfied Handler<_, _>. The server is Unix-socket-only (uses hyper::serve_connection, not serve_with_connect_info), so connect_info was always None at runtime — dead weight. Headers (x-caller-ip, x-forwarded-for) cover the TCP fallback via extract_caller_ip. Verified: hero_builder --release --install: 3/3 binaries built. Resolves s81 carry-over: https://forge.ourworld.tf/lhumina_code/home/issues/230#issuecomment-31194 (Class E).

mik-tf added 1 commit

2026-05-09 04:37:29 +00:00

fix(server): drop Option<ConnectInfo> extractor for axum 0.8 compat 54ba9f20c8

axum 0.8 dropped the blanket Option<T>: FromRequestParts impl. ConnectInfo
does not implement OptionalFromRequestParts in 0.8, so rpc_handler stopped
satisfying Handler<_, _>. The server is Unix-socket-only (uses
hyper::serve_connection, never serve_with_connect_info), so connect_info
was always None at runtime — pure dead weight. Headers (x-caller-ip,
x-forwarded-for) already cover the TCP fallback path via extract_caller_ip.

Verified via hero_builder --release --install: 3/3 binaries built, including
hero_codescalers_server.

Resolves the s81 carry-over: lhumina_code/home#230 (comment)

Signed-off-by: mik-tf