lhumina_code/hero_books
19
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Remove legacy sync-books Makefile target #32

New issue
Closed
opened 2026-02-09 14:52:56 +00:00 by mik-tf · 0 comments
mik-tf commented 2026-02-09 14:52:56 +00:00
Owner
Copy link

Current Behavior

The Makefile has a sync-books target that hardcodes 12 git repository URLs, clones them to /tmp/hero_books_sources/, and the example TOML configs reference those /tmp/ paths.

This creates a fragile two-step manual process: run make sync-books, then run hero_books with --config pointing to the /tmp/ paths.

Expected Behavior

hero_books already handles git cloning internally via git_manager.rs and the auto_export pipeline. The sync-books target is legacy and should be removed.

Changes Needed

  1. Remove the sync-books target from Makefile
  2. Remove or update help target that references it
  3. Update example TOML configs in examples/ebooks_local/ to use git URLs in the source field instead of /tmp/ paths (the single_book.toml already has the git URL pattern commented out)

Context

The auto_export pipeline (git_manager + book_collections) is the correct approach — it clones repos, discovers .ai/ebooks/*.toml files, and processes everything automatically.

## Current Behavior The Makefile has a `sync-books` target that hardcodes 12 git repository URLs, clones them to `/tmp/hero_books_sources/`, and the example TOML configs reference those `/tmp/` paths. This creates a fragile two-step manual process: run `make sync-books`, then run hero_books with `--config` pointing to the `/tmp/` paths. ## Expected Behavior hero_books already handles git cloning internally via `git_manager.rs` and the auto_export pipeline. The `sync-books` target is legacy and should be removed. ## Changes Needed 1. Remove the `sync-books` target from `Makefile` 2. Remove or update `help` target that references it 3. Update example TOML configs in `examples/ebooks_local/` to use git URLs in the `source` field instead of `/tmp/` paths (the `single_book.toml` already has the git URL pattern commented out) ## Context The auto_export pipeline (git_manager + book_collections) is the correct approach — it clones repos, discovers `.ai/ebooks/*.toml` files, and processes everything automatically.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
development
development_mik
development_kristof
main
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.1-rc1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books#32
No description provided.