fix(osis): preserve typed FindParams wrapper through the dispatch hop #141

Merged

timur merged 2 commits from issue-140-osis-find-extract-data into development

2026-05-25 11:41:46 +00:00

timur commented

2026-05-25 11:40:45 +00:00

Owner

Summary

crates/osis/src/rpc/rpc2_adapter.rs::extract_data adds "find" to the same arm as "new" / "set" — it now passes the whole params object through ({"ctx": null, "params": <FindParams-JSON>} from the typed SDK call) instead of extracting params.query (the legacy text-search string that codegen no longer emits).
Replaces the now-misleading extract_data_find_pulls_query unit test with extract_data_find_preserves_typed_params_wrapper, pinning the new contract.

Test plan

cargo test --features rpc --lib rpc2_adapter — all 9 unit tests pass, including the new wrapper-preservation test.
Against hero_service @ fe8c78ad with this patch applied: cargo test --workspace --test indexed_multi_find_e2e goes from 0/7 to 6/7 green. The 7th (title_prefix) is fixed by the sibling hero_indexer#31 PR; with both patches in place every _find_* E2E test passes across the bench domain.
Existing CRUD tests (indexed_multi_full_lifecycle, greeter_*) stay green — the new / set extraction path is unchanged.

lhumina_code/hero_rpc#140

## Summary - `crates/osis/src/rpc/rpc2_adapter.rs::extract_data` adds `"find"` to the same arm as `"new"` / `"set"` — it now passes the whole params object through (`{"ctx": null, "params": <FindParams-JSON>}` from the typed SDK call) instead of extracting `params.query` (the legacy text-search string that codegen no longer emits). - Replaces the now-misleading `extract_data_find_pulls_query` unit test with `extract_data_find_preserves_typed_params_wrapper`, pinning the new contract. ## Test plan - `cargo test --features rpc --lib rpc2_adapter` — all 9 unit tests pass, including the new wrapper-preservation test. - Against hero_service @ `fe8c78ad` with this patch applied: `cargo test --workspace --test indexed_multi_find_e2e` goes from 0/7 to 6/7 green. The 7th (`title_prefix`) is fixed by the sibling hero_indexer#31 PR; with both patches in place every `_find_*` E2E test passes across the bench domain. - Existing CRUD tests (`indexed_multi_full_lifecycle`, `greeter_*`) stay green — the `new` / `set` extraction path is unchanged. https://forge.ourworld.tf/lhumina_code/hero_rpc/issues/140

timur added 2 commits

2026-05-25 11:40:45 +00:00