fix(hero_biz_admin): Rust 2024 type inference, axum features, clippy #48

Closed

casper-stevens wants to merge 1 commit from development_fix_build into development

casper-stevens commented

2026-05-08 09:59:52 +00:00

Member

Summary

Add explicit &String type annotations to ~150 closures in handlers/mod.rs — Rust 2024 edition has stricter closure type inference
Fix password if let binding using .as_deref() for unambiguous &str
Add missing axum "form" and "query" features (required when default-features = false)
Remove duplicate effective_base_path import
Add init_hero_log() to logging.rs with HeroLogLayer tracing subscriber (was called in main.rs but not defined)
Fix &PathBuf → &Path in new_with_db_root (clippy::ptr_arg)
Collapse nested if let blocks (clippy::collapsible_if)
Remove unused Path import from services/mod.rs

Test plan

cargo build --workspace passes clean
cargo clippy --workspace --all-targets -- -D warnings passes clean

## Summary - Add explicit `&String` type annotations to ~150 closures in `handlers/mod.rs` — Rust 2024 edition has stricter closure type inference - Fix password `if let` binding using `.as_deref()` for unambiguous `&str` - Add missing axum `"form"` and `"query"` features (required when `default-features = false`) - Remove duplicate `effective_base_path` import - Add `init_hero_log()` to `logging.rs` with `HeroLogLayer` tracing subscriber (was called in `main.rs` but not defined) - Fix `&PathBuf` → `&Path` in `new_with_db_root` (`clippy::ptr_arg`) - Collapse nested `if let` blocks (`clippy::collapsible_if`) - Remove unused `Path` import from `services/mod.rs` ## Test plan - [x] `cargo build --workspace` passes clean - [x] `cargo clippy --workspace --all-targets -- -D warnings` passes clean

casper-stevens added 1 commit

2026-05-08 09:59:53 +00:00

fix(hero_biz_admin): fix Rust 2024 type inference, missing axum features, and clippy errors

Build and Test / build (pull_request) Failing after 9s

Details

c39a63c3f1

- Add explicit &String type annotations to ~150 closures in handlers/mod.rs
  (Rust 2024 edition stricter closure inference requires this)
- Fix password binding: use form.password.as_deref() for unambiguous &str type
- Add axum "form" and "query" features missing from default-features = false
- Remove duplicate effective_base_path import (was imported twice)
- Add init_hero_log() to logging.rs with HeroLogLayer tracing subscriber
- Fix &PathBuf -> &Path in new_with_db_root (clippy::ptr_arg)
- Collapse nested if-let blocks in services/mod.rs and handlers/mod.rs (clippy::collapsible_if)
- Remove unused Path import from services/mod.rs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>