stories island: parallel list + delete confirmation + SDK #29 workaround #98

New issue

Closed

opened 2026-04-21 01:26:55 +00:00 by zaelgohary · 0 comments

zaelgohary commented

2026-04-21 01:26:55 +00:00

Member

Three HIGH-severity issues in the stories island mirroring what was already fixed in Projects:

StoryService::list in services/story_service.rs sequentially awaits each get(&sid) in a loop — N+1 latency. Should batch via futures::future::join_all.
StoryDetailView calls svc.delete(&sid) on a single click with no confirmation modal. Use hero_archipelagos_core::ConfirmDialog.
StoryService::delete returns Err on the SDK bool/String deserialization bug tracked as hero_osis #29. Swallow the "invalid type: boolean" error the same way projects does.

Three HIGH-severity issues in the stories island mirroring what was already fixed in Projects: - `StoryService::list` in `services/story_service.rs` sequentially awaits each `get(&sid)` in a loop — N+1 latency. Should batch via `futures::future::join_all`. - `StoryDetailView` calls `svc.delete(&sid)` on a single click with no confirmation modal. Use `hero_archipelagos_core::ConfirmDialog`. - `StoryService::delete` returns `Err` on the SDK bool/String deserialization bug tracked as hero_osis #29. Swallow the `"invalid type: boolean"` error the same way projects does.