Quality: String-based error handling — should use typed errors #95

New issue

Open

opened 2026-05-11 13:48:54 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-11 13:48:54 +00:00

Owner

Severity: Low

Location

Multiple locations — mcp.rs, chat.rs, router.rs

Finding

Errors are frequently passed as String or anyhow::Error without structured error types:

pub enum McpError {
    SpawnError(String),
    IoError(String),
    ParseError(String),
    Timeout(String),
}```

## Recommendation
- Use typed errors with structured data (not String)
- Implement `std::error::Error` for all error types
- Add error codes for API responses

## Severity: Low ## Location Multiple locations — `mcp.rs`, `chat.rs`, `router.rs` ## Finding Errors are frequently passed as `String` or `anyhow::Error` without structured error types: ```rust pub enum McpError { SpawnError(String), IoError(String), ParseError(String), Timeout(String), }``` ## Recommendation - Use typed errors with structured data (not String) - Implement `std::error::Error` for all error types - Add error codes for API responses