Quality: Bloated Config struct — should be split into sub-configs #94

New issue

Open

opened 2026-05-11 13:48:54 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-11 13:48:54 +00:00

Owner

Severity: Low

Location

crates/hero_aibroker_lib/src/config/mod.rs

Finding

The Config struct has 40+ fields covering unrelated concerns:

Provider API keys (5+ fields)
Rate limiting (2 fields)
Auth (3 fields)
MCP servers (nested config)
Mother brokers (nested config)
HTTP headers (2 fields)
OpenRouter-specific settings (3 fields)
Model registry paths
And more...

Recommendation

Split into sub-configs: ProviderConfig, AuthConfig, ServerConfig, McpConfig, CascadeConfig
Use composition instead of one giant struct
Each sub-config validates itself

## Severity: Low ## Location `crates/hero_aibroker_lib/src/config/mod.rs` ## Finding The `Config` struct has 40+ fields covering unrelated concerns: - Provider API keys (5+ fields) - Rate limiting (2 fields) - Auth (3 fields) - MCP servers (nested config) - Mother brokers (nested config) - HTTP headers (2 fields) - OpenRouter-specific settings (3 fields) - Model registry paths - And more... ## Recommendation - Split into sub-configs: `ProviderConfig`, `AuthConfig`, `ServerConfig`, `McpConfig`, `CascadeConfig` - Use composition instead of one giant struct - Each sub-config validates itself