Operational: No structured logging — mixed log formats across components #101

New issue

Open

opened 2026-05-11 13:49:53 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-11 13:49:53 +00:00

Owner

Severity: Low

Location

Multiple files: logging.rs, log.rs, and various log_info! macros

Finding

The project uses custom logging macros and ad-hoc log formatting:

macro_rules! log_info {
    ($src:expr, $fmt:expr, $($arg:tt)*) => { ... }
}

No structured logging (JSON format)
No correlation IDs for request tracing
Logs are written to custom paths without rotation
No log level configuration per-component

Recommendation

Adopt tracing with structured fields
Add request correlation IDs
Implement log rotation (size and time-based)
Per-component log level configuration

## Severity: Low ## Location Multiple files: `logging.rs`, `log.rs`, and various `log_info!` macros ## Finding The project uses custom logging macros and ad-hoc log formatting: ```rust macro_rules! log_info { ($src:expr, $fmt:expr, $($arg:tt)*) => { ... } } ``` - No structured logging (JSON format) - No correlation IDs for request tracing - Logs are written to custom paths without rotation - No log level configuration per-component ## Recommendation - Adopt `tracing` with structured fields - Add request correlation IDs - Implement log rotation (size and time-based) - Per-component log level configuration