feat: add prometheus and grafana #4

salmaelsoly · 2026-03-15T09:02:29Z

salmaelsoly commented

2026-03-15 09:02:29 +00:00

#2

#2 ![image](/attachments/72783b73-940d-485b-8c1a-aeea1e4d1368)

image.png

69 KiB

image.png

70 KiB

salmaelsoly added 3 commits

2026-03-15 09:02:29 +00:00

feat: integrate Prometheus metrics for request tracking and error handling

CI / test (push) Waiting to run

Details

0f6b3240e9

feat: integrate grafana

CI / test (push) Waiting to run

Details

ec25fe2b61

feat: add health check endpoint

CI / test (push) Successful in 1m26s

Details

2ee16189c2

salmaelsoly force-pushed developemnt_prometheus from 2ee16189c2

CI / test (push) Successful in 1m26s

Details

to 1158f898af

CI / test (push) Successful in 1m2s

Details

2026-03-17 09:35:03 +00:00

Compare

salmaelsoly added 1 commit

2026-03-17 09:53:44 +00:00

docs: update README with Docker Compose instructions for Prometheus and Grafana

CI / test (push) Successful in 1m1s

Details

c80dd2d454

salmaelsoly changed title from ~~WIP: feat: add prometheus and grafana~~ to feat: add prometheus and grafana

2026-03-17 09:55:24 +00:00

rawan requested changes

2026-03-17 12:46:39 +00:00

Dismissed

src/main.rs Outdated

					
				@ -90,0 +117,4 @@

				    } else {

				        "connect_info"

				    };

				    state.metrics.record_source(source);

record_source is called after IP resolution, so failed requests don't record a source. Source counts won't sum to total requests

is this the expected behaviour?

`record_source` is called after IP resolution, so failed requests don't record a source. Source counts won't sum to total requests is this the expected behaviour?

yes, record_source only makes sense when we actually have a valid IP to look up it increments total lookups but by source

 let lookup_source = Family::default();
        registry.register(
            "geoip_lookup_source",
            "Total lookups by IP source",
            lookup_source.clone(),
        );

yes, record_source only makes sense when we actually have a valid IP to look up it increments total lookups but by source ``` let lookup_source = Family::default(); registry.register( "geoip_lookup_source", "Total lookups by IP source", lookup_source.clone(), ); ```

src/metrics.rs Outdated

					
				@ -0,0 +36,4 @@

				    pub requests: Family<RequestLabels, Counter>,

				    pub request_duration_seconds: Histogram,

				    pub lookup_errors: Family<ErrorLabels, Counter>,

				    pub lookup_source: Family<SourceLabels, Counter>,

Access of these four variables goes through record_ methods
so these fields should be private to avoid direct access to them

Access of these four variables goes through record_ methods so these fields should be private to avoid direct access to them

salmaelsoly marked this conversation as resolved

src/metrics.rs Outdated

					
				@ -0,0 +113,4 @@

				/// Handler that renders all registered metrics in OpenMetrics text format.

				pub async fn metrics_handler(State(state): State<super::AppState>) -> impl IntoResponse {

				    let mut buffer = String::new();

				    encode(&mut buffer, &state.metrics_registry).unwrap();