coopcloud_code/projectmycelium_marketplace
Archived
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix wallet page to use WalletManager trait via ServiceProvider #14

New issue
Closed
opened 2026-02-09 21:04:28 +00:00 by mik-tf · 3 comments
mik-tf commented 2026-02-09 21:04:28 +00:00
Owner
Copy link

Problem

The wallet page shows balance 0, no transactions, no owned products, and staking at 0. The wallet controller at src/controllers/wallet.rs (953 lines) uses FixtureWalletManager which reads from JSON fixture files instead of hero_osis KVS.

Current Implementation

The dashboard_wallet_page handler does use services.wallet.get_balance() but the template-rendering path also directly reads fixture data for:

  • Transaction history
  • Owned products list
  • Staking information
  • Wallet address display

What Works

The hero WalletManager implementation already exists at src/services/impl_hero/wallet_manager.rs (302 lines) with:

  • Hybrid on/off-chain balance (KVS ledger + NEAR token queries)
  • Transaction history via KVS
  • Balance operations

What Needs Fixing

  1. Ensure dashboard_wallet_page fully uses services.wallet.* for all data
  2. Wire transaction list to services.wallet.get_transactions()
  3. Wire owned products to services.orders.* (completed orders = owned)
  4. Wire staking display to services.wallet.get_staking_info() or hero_ledger
  5. Verify seed script includes wallet test data (balances + transactions)

Acceptance Criteria

  • Wallet shows non-zero balance from hero_osis KVS
  • Transaction history displays seeded transactions
  • Owned products section shows completed orders
  • Staking section shows data (or appropriate empty state if not staked)
  • All wallet operations go through WalletManager trait

Dependencies

  • Depends on: #9 (split dashboard.rs)
  • Independent of provider rewiring issues
## Problem The wallet page shows balance 0, no transactions, no owned products, and staking at 0. The wallet controller at `src/controllers/wallet.rs` (953 lines) uses `FixtureWalletManager` which reads from JSON fixture files instead of hero_osis KVS. ## Current Implementation The `dashboard_wallet_page` handler does use `services.wallet.get_balance()` but the template-rendering path also directly reads fixture data for: - Transaction history - Owned products list - Staking information - Wallet address display ## What Works The hero `WalletManager` implementation already exists at `src/services/impl_hero/wallet_manager.rs` (302 lines) with: - Hybrid on/off-chain balance (KVS ledger + NEAR token queries) - Transaction history via KVS - Balance operations ## What Needs Fixing 1. Ensure `dashboard_wallet_page` fully uses `services.wallet.*` for all data 2. Wire transaction list to `services.wallet.get_transactions()` 3. Wire owned products to `services.orders.*` (completed orders = owned) 4. Wire staking display to `services.wallet.get_staking_info()` or hero_ledger 5. Verify seed script includes wallet test data (balances + transactions) ## Acceptance Criteria - [ ] Wallet shows non-zero balance from hero_osis KVS - [ ] Transaction history displays seeded transactions - [ ] Owned products section shows completed orders - [ ] Staking section shows data (or appropriate empty state if not staked) - [ ] All wallet operations go through WalletManager trait ## Dependencies - Depends on: #9 (split dashboard.rs) - Independent of provider rewiring issues
mik-tf commented 2026-02-09 21:52:09 +00:00
Author
Owner
Copy link

Wallet page already uses services.wallet.get_balance() and get_transactions(). Core operations fully wired.

Wallet page already uses services.wallet.get_balance() and get_transactions(). Core operations fully wired.
mik-tf commented 2026-02-09 22:54:24 +00:00
Author
Owner
Copy link

Reopened — remaining work

Remaining bypasses in wallet.rs:

  • 2x UserPersistence::load_user_data
  • 2x CurrencyService::new() (utility, keep)
  • 3x InstantPurchaseService::builder() (refactor to use WalletManager)
  • 2x NavbarService::builder() (UI helper, refactor to use existing traits)
  • 2x AutoTopUpService::builder() (needs WalletManager trait methods)

Depends on #26 for WalletManager auto-topup methods.

## Reopened — remaining work Remaining bypasses in wallet.rs: - 2x `UserPersistence::load_user_data` - 2x `CurrencyService::new()` (utility, keep) - 3x `InstantPurchaseService::builder()` (refactor to use WalletManager) - 2x `NavbarService::builder()` (UI helper, refactor to use existing traits) - 2x `AutoTopUpService::builder()` (needs WalletManager trait methods) Depends on #26 for WalletManager auto-topup methods.
mik-tf commented 2026-04-22 12:01:29 +00:00
Author
Owner
Copy link

archived repo, closing

archived repo, closing
Commenting is not possible because the repository is archived.
No Branch/Tag specified
Branches Tags
development
main
No results found.
Labels
Clear labels   
architecture

System design, planning, documentation

  
backend

Backend / Rust code changes

  
bug

Something is not working correctly

  
enhancement

New feature or improvement

  
frontend

Frontend / templates / CSS / JS changes

  
infrastructure

Deployment, CI/CD, Docker, configuration

  
phase-1

Phase 1: OSIS Production Ready

  
phase-2

Phase 2: Platform Enhancement

  
refactor

Code restructuring without behavior change

No labels
architecture
backend
bug
enhancement
frontend
infrastructure
phase-1
phase-2
refactor
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coopcloud_code/projectmycelium_marketplace#14
No description provided.